Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled containedctx linter #1211

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Enabled containedctx linter #1211

merged 2 commits into from
Apr 23, 2024

Conversation

asmyasnikov
Copy link
Member

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #920

What is the new behavior?

Other information

Copy link

github.com/ydb-platform/ydb-go-sdk/v3/trace

incompatible changes

DatabaseSQLOnTxPrepare: changed from func(*DatabaseSQL, *context.Context, call, *context.Context, tableTransactionInfo, string) func(error) to func(*DatabaseSQL, *context.Context, call, context.Context, tableTransactionInfo, string) func(error)
DatabaseSQLTxPrepareStartInfo.TxContext: changed from *context.Context to context.Context
TopicOnReaderCommit: changed from func(*Topic, context.Context, string, int64, int64, int64, int64) func(error) to func(*Topic, *context.Context, string, int64, int64, int64, int64) func(error)
TopicOnReaderPartitionReadStartResponse: changed from func(*Topic, string, context.Context, string, int64, int64) func(readOffset *int64, commitOffset *int64, _ error) to func(*Topic, string, *context.Context, string, int64, int64) func(readOffset *int64, commitOffset *int64, _ error)
TopicOnReaderPartitionReadStopResponse: changed from func(*Topic, string, context.Context, string, int64, int64, int64, bool) func(error) to func(*Topic, string, *context.Context, string, int64, int64, int64, bool) func(error)
TopicOnReaderReadMessages: changed from func(*Topic, context.Context, int, int, int) func(messagesCount int, topic string, partitionID int64, partitionSessionID int64, offsetStart int64, offsetEnd int64, freeBufferCapacity int, _ error) to func(*Topic, *context.Context, int, int, int) func(messagesCount int, topic string, partitionID int64, partitionSessionID int64, offsetStart int64, offsetEnd int64, freeBufferCapacity int, _ error)
TopicReaderCommitStartInfo.RequestContext: changed from context.Context to *context.Context
TopicReaderPartitionReadStartResponseStartInfo.PartitionContext: changed from context.Context to *context.Context
TopicReaderPartitionReadStopResponseStartInfo.PartitionContext: changed from context.Context to *context.Context
TopicReaderReadMessagesStartInfo.RequestContext: changed from context.Context to *context.Context

summary

Base version: v3.65.4-0.20240419132736-e0a1158657c8 (master)
Cannot suggest a release version.
Can only suggest a release version when compared against the most recent version of this major: v3.65.3.

Copy link

github-actions bot commented Apr 21, 2024

🌋 Here are results of SLO test for Go SDK gorm:

Grafana Dashboard

SLO-gorm

Copy link

github-actions bot commented Apr 21, 2024

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over table-service:

Grafana Dashboard

SLO-native-table

Copy link

github-actions bot commented Apr 21, 2024

🌋 Here are results of SLO test for Go SDK database/sql:

Grafana Dashboard

SLO-database-sql

Copy link

github-actions bot commented Apr 21, 2024

🌋 Here are results of SLO test for Go SDK xorm:

Grafana Dashboard

SLO-xorm

@asmyasnikov asmyasnikov merged commit d716a3b into master Apr 23, 2024
36 checks passed
@asmyasnikov asmyasnikov deleted the containedctx branch April 23, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants